rust-lang/rust-clippy

Lint functions taking references as arguments but only use them to create an owned value

Open

#1,563 建立於 2017年2月21日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Rust (10,406 star) (1,391 fork)batch import
A-lintE-hardL-unnecessaryT-middlegood first issue

描述

A function that takes a &str and always converts it to a String, should be taking a String argument instead. This is hard to generalize, but we could start with anything implementing to_owned and only calling to_owned.

貢獻者指南

技術棧
rust
領域
tooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Rust knowledgefamiliarity with Clippy lint implementation
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
This issue proposes a new lint for Clippy that checks functions taking a reference (like `&str`) but only using it to create an owned value (like `to owned()`). To implement, examine existing lints in the `clippy lints` crate, particularly those in `src/clippy lints/` that deal with function arguments and type checking. Look at the lint 'needless pass by value' as a reference. The current issue lacks a specific implementation strategy; a good starting point is to discuss the lint's scope and possible false positives with maintainers before coding.