`std_wildcard_imports` to lint against `use std::mod::*`

(4 則留言) (1 個反應) (1 位負責人)Rust (1,391 個分叉)batch import

A-lintE-help-wantedgood first issue

倉庫指標

星標: (10,406 顆星)
PR 合併指標: (平均合併 19天 22小時) (30 天內合併 113 個 PR)

描述

What it does

This is a version of wildcard_imports that affects only imports from the standard crates std, core, proc_macro, alloc, and test.

Advantage

wildcard_imports is in pedantic, which seems reasonable for most crates. However, using glob imports from the standard library means that upgrading Rust version can break the build. Recent examples:

I am proposing std_wildcard_imports as a separate lint from wildcard_imports so it can get enabled by default, likely in clippy::style (or possibly uplifted https://github.com/rust-lang/rust/issues/135672#issuecomment-2605426121)

Drawbacks

Confusion between wildcard_imports and std_wildcard_imports, noise on existing code, sometimes use proc_macro::* or similar is fine for testing.

Example

Lint on glob imports:

use std::mem::*; // error
use core::sync::*; // error
use proc_macro::*; // error

However, using glob imports from prelude modules should not raise this warning:

use std::io::prelude::*; // ok
use std::prelude::rust_2021:* // unlikely, but still ok

Non-std crates don't raise this lint

use regex::*; // ok

貢獻者指南

研究方向: 研究 clippy 關於添加新 lint 的文件（https://doc.rust lang.org/clippy/development/adding lints.html）。然後按照指南在 style 類別中實現 `std wildcard imports` 這個新 lint。查看現有的 lint（如 `wildcard imports`）作為參考。了解如何檢測全域導入並按路徑（std、core、proc macro、alloc、test）進行過濾。創建一個新的 lint pass 並註冊它。編寫測試並更新 lint 列表。
技術棧: rust
領域: tooling
議題類型: 功能
難度: 2
預計時間: 半天
活動狀態: 活躍
清晰度: 清晰
前置要求: RustGit
新手友善度: 70