Lint to warn about str::as_ptr() usage in ffi call · rust-lang/rust-clippy#1236

(0 留言) (0 反應) (0 負責人)Rust (10,406 star) (1,391 fork)batch import

A-lintL-correctnessT-middlegood first issue

描述

Hello. It would be nice to have a warning when using str::as_ptr() in a ffi call instead of using CStr.

For instance, in the following code:

unsafe { printf("Hello".as_ptr() as *const _) };

should give a warning and propose something like:

let cstring = CString::new("Hello".as_bytes()).unwrap();
unsafe { printf(cstring.as_ptr()) };

Thanks to add this lint.

技術棧: rust
領域: developer experiencetooling
議題類型: feature
難度: 3
預計時間: 1-3 hours
活動狀態: stale
清晰度: clear
前置要求: familiarity with Rust FFIclippy lint creation basicsunderstanding of CStr
新手友善度: 60
研究方向: Examine existing clippy lints that target function calls (e.g., the 'fn to numeric cast' lint) to understand the pattern matching on function arguments. Follow the clippy development guide at https://github.com/rust lang/rust clippy/blob/master/CONTRIBUTING.md to set up the environment and add a new lint. The lint should detect calls to `str::as ptr()` where the result is passed to an extern function; consider using `fn has item` or checking the function call's parameter types.