rust-lang/rust-clippy

lint usage of struct constructors when new/from method is available

Open

#1,216 建立於 2016年9月5日

在 GitHub 查看
 (7 留言) (0 反應) (0 負責人)Rust (10,406 star) (1,391 fork)batch import
A-lintL-styleT-middlegood first issue

描述

if a struct has a new or a from method that does the same as a struct constructor, then that method should be used instead of the struct constructor.

Obviously the usage of a struct constructor inside the new or from method should not be linted.

貢獻者指南

技術棧
rust
領域
tooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Rust programmingClippy contribution guideAST manipulation basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Start by reading the clippy documentation for contributing new lints. Look at the `clippy lints` directory for examples of lints that check function calls, such as `new ret no self` (file: clippy lints/src/new ret no self.rs). Understand how to implement a lint pass that checks struct expressions and compares them to available new/from methods. Review the issue comments for any additional design considerations.