rust-lang/rust-clippy

`bool_comparison` should not fire when testing for false

Open

#1,043 建立於 2016年6月26日

在 GitHub 查看
 (4 留言) (2 反應) (0 負責人)Rust (10,406 star) (1,391 fork)batch import
A-lintL-styleS-needs-discussiongood first issue

描述

I think that the bool_comparison lint should not fire when the comparison is var == false because, at least I, find that version much easier to see when quickly scrolling through the code than the !var as it is too simple to miss that single !. However, I'm just putting this here for discussion I'll go turn the lint off in that specific place.

Enjoy your rusty endeavors.

貢獻者指南

技術棧
rust
領域
toolingdeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic rustclippy lint architecture
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
Examine the bool comparison lint implementation in clippy lints/src/bool comparison.rs. Review the issue comments for any maintainer feedback or prior attempts. The change likely involves adding an exception for `== false` comparisons or adding a configuration option. Implement the change and include tests.