rust-lang/rust-analyzer

Expression lowering uses unreasonable amount of stack space

Open

#5,317 建立於 2020年7月11日

在 GitHub 查看
 (3 留言) (0 反應) (1 負責人)Rust (14,924 star) (1,726 fork)batch import
A-perfC-enhancementE-hardS-actionablefungood first issue

描述

Our lowering code for expressions is a single giant match, and looks like it consumes a lot of stack space, even in release mode.

See https://github.com/rust-analyzer/rust-analyzer/pull/5316/commits/12d52a726a1e6ca0f6b08343d13d0f6b50d94d8c for some ways to observe this.

It would be nice to optimize this!

貢獻者指南

技術棧
rust
領域
performancetooling
議題類型
performance
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
5
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Rust programmingcompiler internalsexpression lowering
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
10
研究方向
Investigate the expression lowering code in the rust analyzer repository, specifically the giant match statement that consumes excessive stack space. Review the referenced commit (12d52a7) in PR #5316 for methods to observe stack usage. Consider splitting the match into separate functions or using boxed closures to reduce stack depth. Look for any existing comments or discussion on the issue for additional context.