rtk-ai/rtk

gradle.toml matcher does not match real `rtk ./gradlew` / `rtk gradle` invocations

Open

#1,177 建立於 2026年4月10日

在 GitHub 查看
 (1 留言) (1 反應) (0 負責人)Rust (48,085 star) (2,914 fork)batch import
bugeffort-smallfilter-qualitygood first issue

描述

src/filters/gradle.toml currently has a match_command that does not match the command string RTK actually looks up at runtime, so Gradle output falls back to passthrough.

MWE

# in any Gradle project with ./gradlew present
RTK_TOML_DEBUG=1 rtk ./gradlew tasks

# actual:
# [rtk:toml] looking up filter for: "gradlew tasks" (58 filters loaded)
# [rtk:toml] no filter matched — passthrough

Expected

[rtk:toml] matched filter: 'gradle'

Debug

RTK_TOML_DEBUG=1 rtk ./gradlew tasks
RTK_TOML_DEBUG=1 rtk gradle tasks # if a gradle executable is on the path

Local workaround Use a user/project filter override with:

match_command = "^(?:\\./)?gradlew?\\b"

Proposed fix in rtk

  • Update src/filters/gradle.toml matcher to match the normalized lookup string.
  • Add inline tests for gradlew ... and ./gradlew ....
  • Add an integration test covering actual fallback lookup behavior.

Context

  • Similar fix was already proposed in PR #966, but it was closed unmerged.
  • Related: #1178.

貢獻者指南

技術棧
rustshell
領域
clitooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic regexTOML configuration
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
The fix requires updating the match command regex in `src/filters/gradle.toml` to match commands like `gradlew` or `./gradlew` with arguments. Similar work was attempted in PR #966, which was closed unmerged; reviewing that PR may provide insights. The issue also references #1178 for context. The solution should also add inline tests in the same file and possibly an integration test to verify the fallback lookup behavior. The maintainer has not yet commented on scope, but the issue is well defined.