rtfpessoa/diff2html

Show "no newline at end of file" warning

開放

#157 建立於 2017年12月18日

 (2 則留言) (7 個反應) (0 位負責人)TypeScript (302 個分叉)user submission
enhancementhacktoberfesthelp wanted

倉庫指標

星標
 (3,368 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

Show "no newline at end of file" warning like in GitHub.


Step 1: Describe the problem:

Often text editors add new lines at EOF to comply with UNIX standard as git expects. When such newlines are introduced (or accidentally removed) to an already tracked file, this diff viewer doesn't offer a visual clue about that missing invisible character. Please note that git-diff shows a warning for this case in the terminal and GitHub supports it on their diff viewer.

Steps to reproduce:

  1. Create a text file that does not end with a new line character and commit it.
  2. Add a new line at the end of that file and commit it.
  3. Perform the diff with diff2html CLI.

Observed Results:

  • The last line is correctly marked as changed, but it is not visible what exactly changed in there.

Expected Results:

  • A "no newline at end of file" mark next the version missing it, like the one GitHub shows on their diff viewer.

貢獻者指南