rtfeldman/seamless-immutable

isMergableObject returns true for an empty object

Open

#82 建立於 2015年12月28日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (5,367 star) (221 fork)batch import
bughelp wanted

描述

      function addToResult(currentObj, otherObj, key) {
      var immutableValue = Immutable(otherObj[key]);
      var mergerResult = merger && merger(currentObj[key], immutableValue, config);
      var currentValue = currentObj[key];

      console.log("IS NEW OBJECT MERGABLE", isMergableObject(new Object()));

  -> seamless-immutable.js:306 IS NEW OBJECT MERGABLE true

In my production build currentValue is sometimes an empty object, and with deep merge enabled we error out when trying to call merge() on said object. In dev mode this never seems to happen.

I've worked around this with an additional check to isMergableObject which checks that Object.keys(target).length > 0. If this seems like an acceptable fix I'd love to submit a PR.

貢獻者指南

isMergableObject returns true for an empty object · rtfeldman/seamless-immutable#82 | Good First Issue