rtfeldman/seamless-immutable

Fix tests that relied on Lodash 4

Open

#179 建立於 2016年12月11日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)JavaScript (5,367 star) (221 fork)batch import
help wanted

描述

I mistakenly upgraded our tests to use Lodash 4, not realizing some of the features in Lodash 4 did not work in IE9-10. (seamless-immutable itself does not depend on Lodash; this was for tests only.)

We subsequently added tests that relied on those features, causing IE9-10 tests to fail. I have reverted to Lodash 3.10 and disabled those tests, so that the other tests can complete cross-browser testing as normal. However, now we have a few pending tests that need to be rewritten to use Lodash 3.10 features instead of the Lodash 4 features they currently use.

The pending tests are marked with xit in the test suite.

Help on this would be greatly appreciated! ❤️

貢獻者指南

技術棧
javascript
領域
testing
議題類型
test
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScript fundamentalsLodash experience
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Locate the tests marked with `xit` in the test suite. Identify which Lodash 4 features were used and replace them with equivalent Lodash 3.10 functions. The test files are likely in the repository's test directory. Refer to Lodash 3.10 documentation for compatibility.