robotframework/SeleniumLibrary

alert issue in acceptance tests

Open

#1,349 建立於 2019年3月20日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Python (1,252 star) (714 fork)batch import
help wantedpriority: mediumtask

描述

I just withnessed following issue:

Running Acceptance . Keywords . Alerts . Alert Should Not Be Present with custom timeout left a alert open after a test failure and that caused a trickle down effect of quite a lot of tests failing due to following error:

UnexpectedAlertPresentException: Alert Text: None Message: unexpected alert open: {Alert text : Alert after 500ms!} (Session info: chrome=72.0.3626.121) (Driver info: chromedriver=2.46.628411 (3324f4c8be9ff2f70a05a30ebc72ffb013e1a71e),platform=Mac OS X 10.14.3 x86_64)

Maybe the alert tests should have test suite and teardown to open & close the browser to avoid this sort of flakyness ?

貢獻者指南

技術棧
python
領域
testing
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Robot FrameworkSeleniumLibraryPython
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue describes a flaky test where an alert remains open after a failure, causing subsequent tests to fail. The suggested fix is to add a test suite teardown that closes the browser after each test suite. To implement, examine the acceptance test files in the repository, likely under 'atest/acceptance/'. Look for existing suite teardown patterns in other test files and add a teardown that closes the browser to the alert tests. Ensure the teardown runs even on test failure. Refer to the Robot Framework documentation for suite teardowns.
alert issue in acceptance tests · robotframework/SeleniumLibrary#1349 | Good First Issue