rlworkgroup/garage

Add versioning to pickle file

Open

#1,278 建立於 2020年4月3日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Python (1,728 star) (297 fork)batch import
good first issue

描述

We need to add versioning to pickle file to prevent people from loading a pickling file that is generated by an old version of garage. Doing so will almost always fail, with meaningless error messages, but the folks might not be aware of the root cause.

貢獻者指南

技術棧
python
領域
backenddata
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
understanding of Python picklefamiliarity with garage's serialization
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate the current pickle saving and loading mechanism in garage. Look for existing versioning or metadata in pickled files. Propose a version number and a check during loading to prevent loading incompatible pickles. Consider using a dictionary wrapper with a version key. See `garage/experiment/snapshotter.py` and related test files.