rkt/rkt

Several functional tests may be unnecessarily(?) running rkt with --debug

Open

#2,702 建立於 2016年5月26日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Go (8,871 star) (865 fork)batch import
area/developer toolingarea/testinghelp wantedkind/enhancement

描述

It looks like many functional tests (~100 according to a quick grep) are running rkt with --debug. Given that we are having some long running-time issues for the testsuite, it may be worth having a look if we can gain some time from shaving those.

This came up in a review for an unrelated PR introducing some functional tests.

貢獻者指南

技術棧
go
領域
testing
議題類型
performance
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
shell scripting
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Search for all functional test files that run `rkt` with ` debug` flag using `grep`. For each occurrence, evaluate whether the debug output is required for the test to pass or if it can be removed to speed up the test suite. Refer to the discussion in PR #2656 for context on why this was brought up. Since the rkt project is concluded, this issue may not be actively maintained, but the investigation could be done locally.