rizinorg/cutter

Comments window should show unescaped comments whenever possible

Open

#2,961 建立於 2022年6月7日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)C++ (14,852 star) (1,123 fork)batch import
good first issue

描述

See the comment at 0x1400022c6 address, it's a Chinese words 好的, which are shown in the disassembly but neither in Cutter nor in the Rizin's CCl output:

image

Originally posted by @XVilka in https://github.com/rizinorg/cutter/issues/2960#issuecomment-1148768300

貢獻者指南

技術棧
cpp
領域
desktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C++Qt frameworkUnicode encoding
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate the Comments window implementation in Cutter (likely in src/gui/CommentsWidget.cpp or similar). Check how comments are fetched from Rizin and displayed via Qt's QString. The issue suggests that unescaped Unicode characters are not displayed; perhaps the string is being escaped before display. Look at the 'CCl' output of Rizin and compare with raw comment data. Ensure that the text is treated as UTF 8 and not as ASCII. Consider using QTextCodec or QString::fromUtf8. Refer to the linked issue #2960 for context.