rizinorg/cutter

asm.lines.fcn doesn't work

Open

#2,190 建立於 2020年5月10日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)C++ (14,852 star) (1,123 fork)batch import
BUGHelp WantedUI

描述

Environment information

  • Operating System: ArchLinux
  • Cutter version: 1.10.3
  • Obtained from:
    • Built from source
    • Downloaded from release
    • Distribution repository
  • File format: x86_64 ELF

Describe the bug

Cutter settings contain option "Show function boundary lines (asm.lines.fcn)" but it gets ignored. DisassemblyWidget sets set("asm.lines", false); when retrieving disassembly, this was probably added when switching from ascii arrows to drawing arrows in cutter.

To Reproduce

Steps to reproduce the behavior:

  1. Open Cutter
  2. Observe that "Show function boundary" but there is no function boundary indicator
  3. Disable "Show function boundary", observe that nothing changes
  4. Enable "Show function boundary", still no function boundary indicator

Expected behavior

When asm.lines.fcn is true function function boundaries are visualized.

Screenshots

Additional context

貢獻者指南

技術棧
cpp
領域
desktoptooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C++Qt
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The bug is caused by a forced `set("asm.lines", false);` in the DisassemblyWidget code that overrides the user's `asm.lines.fcn` setting. Locate the file containing that widget and modify it to respect the `asm.lines.fcn` configuration. Ensure that when `asm.lines.fcn` is enabled, the function boundary lines are drawn as expected.