rigor789/vue-scrollto

v-scroll-to breaks HTML5 form validation with Enter

Open

#155 建立於 2019年9月9日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (1,966 star) (114 fork)batch import
help wanted

描述

Problem

If a HTML form has a button with v-scroll-to, that breaks form validation which occurs when a user presses Enter.

Steps to reproduce

  1. Open jsfiddle at https://jsfiddle.net/semenov/ukt84qvy/7/
  2. Type something in input 1, press Enter. The form validation for input 2 will NOT kick in, instead the page will be scrolled to a seemingly random (?) location:
  1. Edit jsfiddle, remove v-scroll-to, re-run it.
  2. Type something in input 1, press Enter. The form validation for input 2 WILL kick in, and the page will be scrolled to show input 2:

Expected behavior

Regardless of v-scroll-to, pressing Enter in a form scrolls to the input element that doesn't pass validation.

貢獻者指南

技術棧
javascriptvue
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Vue.js basicsHTML form events
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue is that the v scroll to directive intercepts the Enter key press event, preventing the form's default validation behavior. Investigate the directive's event handler in the source code (likely in src/index.js or similar). The fix should ensure that the directive only triggers scrolling when the click event comes from a button/input not in a form submission context, or delegate to the form's submit event. The jSFiddle provides a minimal reproduction.