rev087/ng-inspector

Further issues barring entrance to the Mozilla Add-ons gallery

Open

#113 建立於 2015年5月26日

在 GitHub 查看
 (8 留言) (0 反應) (0 負責人)JavaScript (787 star) (100 fork)batch import
firefoxhelp wanted

描述

Your version was rejected because of the following problems:

  1. Dynamic creation of script nodes can be unsafe if contents are not static or are otherwise unsafe, or if src is remote. ng-inspector/data/inject.js 5
  2. The "mouseover", "mouseout" events are dispatched with high frequency and can cause performance issues. Use mutation observers instead https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver

Tested on Ubuntu 14.04 with Firefox v38

  1. is debatable, although we do create a script node, the contents are static and are not remote. What they consider unsafe exactly might be the bigger issue.
  2. could be solved by either the suggested method, or better yet (imo) using delegate events, which is a long overdue optimization either way.

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Basic JavaScriptBrowser extension concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Examine ng inspector/data/inject.js line 5 to understand the dynamic script node creation. The content is static and not remote, so consider if any change is necessary or if the Mozilla reviewer's concern can be addressed with a comment. For the second issue, replace mouseover/mouseout events with MutationObserver or event delegation. Review the current event handling in the codebase and implement the chosen approach. Check the issue comments for maintainer insights on preferred solution.