Copier manager doesn't set `isExecutable` on added/modified files · renovatebot/renovate#42239

(0 留言) (0 反應) (0 負責人)TypeScript (14,066 star) (1,916 fork)batch import

help wantedmanager:copierpriority-3-medium

描述

As noted in https://github.com/renovatebot/renovate/discussions/41438, when we're not making sure that the isExecutable flag in https://github.com/renovatebot/renovate/blob/42ee883ab854a5be7f86309858014e55fc5ee62b/lib/util/git/types.ts#L63 is set.

For instance, using the minimal repro:

% copier --version
copier 9.14.0
% copier update --skip-answered --defaults --answers-file .copier-answers.yml --vcs-ref v1.1.0
Updating to template version 1.1.0
jamietanna@caerbannog .venv tmp 41438 (git)-[main]* % gst
## main...origin/main
 M .copier-answers.yml
?? bin/
jamietanna@caerbannog .venv tmp 41438 (git)-[main]* % ls bin
deploy.sh
jamietanna@caerbannog .venv tmp 41438 (git)-[main]* % ls -al bin
total 4
drwxr-xr-x 3 jamietanna staff  96 Mar 30 09:45 .
drwxr-xr-x 8 jamietanna staff 256 Mar 30 09:45 ..
-rwxr-xr-x 1 jamietanna staff  48 Mar 30 09:45 deploy.sh

This does correctly copy an executable file, but when Renovate commits it does not set the isExecutable flag.

We need to correctly identify this, and then set it.

貢獻者指南

技術棧: typescriptnodejs
領域: backendtooling
議題類型: bug
難度: 2
預計時間: 1-3 hours
活動狀態: fresh
清晰度: clear
前置要求: basic TypeScriptunderstanding of git file permissions
新手友善度: 85
研究方向: The fix should be in `lib/modules/manager/copier/artifacts.ts` around lines 121-138, where file changes are committed. Currently, the `isExecutable` flag from the file stats is not being captured and set on the `FileChange` object. Look at how other managers (e.g., npm) handle executable files, and check the `FileChange` type in `lib/util/git/types.ts`. The goal is to detect executable files (e.g., by checking file mode 755) and set `isExecutable: true` in the `FileChange` before passing to the git commit.