reflux/refluxjs

Reflux stores don't play nice with webpack Hot Module Replacement

Open

#385 建立於 2015年7月31日

在 GitHub 查看
 (7 留言) (0 反應) (0 負責人)JavaScript (5,377 star) (354 fork)batch import
enhancementhelp wanted

描述

If have simple application using Reflux and everything works properly. I'm using webpack to build and run everything with HMR support. The react components get hot swapped properly and also the Actions and Stores get hot swapped. The only problem is the 'old' Store is still active and still reacting to the Actions. So every compile that changes something in a Store, you end up with another version of the Store.

Is there something that can be done to fix this?

貢獻者指南

技術棧
javascriptreact
領域
frontenddeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Reflux store lifecyclewebpack HMRJavaScript closures
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
25
研究方向
Investigate how Reflux stores register with actions. Likely a cleanup mechanism is missing on module replacement. Look at Reflux's Store.js to see how listeners are attached and consider using webpack's module.hot.dispose to detach old stores. Review existing comments for any suggested approaches.