redux-utilities/redux-actions

Should print warning message if type is undefined

Open

#86 建立於 2016年5月6日

在 GitHub 查看
 (7 留言) (1 反應) (1 負責人)JavaScript (6,540 star) (340 fork)batch import
help wanted

描述

Consider this code, it's commonly used in my project:

import * as actionTypes from './actionTypes.js'
export default handleActions({
  [actionTypes.ACT_1]: (state, action) => {},
  [actionTypes.ACT_2]: (state, action) => {},
})

If there's a typo in actionTypes variable(ACE_1 for instance), there's no warning, linters can't tell the error too. But it's easy to print warning message using redux-actions.

I'd like to send a PR if it's okay to you.

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptRedux conceptsredux actions library
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
The issue requests adding a warning when an action type is undefined. Likely the change should be made in the handleActions function, which processes the action map. Check the source code for where types are resolved, and add a console.warn when a type resolves to undefined. No existing PR or assignee activity, so you may start by reviewing the handleActions implementation and proposing a simple warning.