redux-offline/redux-offline

Add tests for reducer

Open

#172 建立於 2018年1月21日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (6,114 star) (424 fork)batch import
help wanted

描述

Can't really refactor the offline reducer #149 until we have some tests. Open discussion about the style change from switch block to objects as flow control.

貢獻者指南

技術棧
javascriptreact
領域
testing
議題類型
test
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
JavaScriptReduxJest
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
First, read the offline reducer code linked in issue #149 to understand the current implementation. Then, review the discussion about changing from switch to object based flow control to decide which style to test. Write a test suite that covers the reducer's main actions and states, following best practices for Redux reducer testing.