realm/SwiftLint

Feature request: Add an option that changes behavior depending on whether attributes have arguments

Open

#5,011 建立於 2023年5月15日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)Swift (19,570 star) (2,295 fork)batch import
enhancementgood first issue

描述

New Issue Checklist

New feature request

The attributes_with_arguments_always_on_line_above option which has added to the attributes rule in version 0.52.0 is only working for variables and imports. I think it would be nice if there was a way to work for functions and types as well.

In the current version, variables and imports can change the behavior of the attributes rule depending on whether their attributes have arguments, but functions and types cannot. I think it would be nice if they had a way to do the same.

An use case:

@objc(Foo)
class Foo: NSObject {
    @objc func foo() {}
}

ref. Google's Swift Style Guide

貢獻者指南

技術棧
swift
領域
tooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Swift programmingbasic SwiftLint rule structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
The issue requests extending the `attributes with arguments always on line above` option to functions and types in the `attributes` rule. Currently, the option only works for variables and imports. The implementation likely involves modifying the rule's logic in the SwiftLint source code to handle function and type declarations similarly. Refer to the existing implementation of the `attributes` rule, specifically how it checks for attribute arguments and enforces line placement. The change should be localized to the rule's file, possibly `AttributesRule.swift`.