readthedocs/sphinx_rtd_theme

Duplicated access key of the prev and next buttons when prev_next_buttons_location == 'both'

Open

#1,057 建立於 2021年2月23日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)CSS (3,473 star) (1,413 fork)batch import
AcceptedBugGood First Issue

描述

Problem

The Chrome Lighthouse auditor report some accessibility problems; _ Color contrast problems in the lateral nav bar _ Missing aria-label in the input search box _ Duplicated access key of the previous and next buttons when variable theme_prev_next_buttons_location == 'both'

Reproducible Project

The first two are available in all rtd doc like: https://sphinx-rtd-theme.readthedocs.io/en/latest/ The third one need variable theme_prev_next_buttons_location == 'both'

Expected Results

Improve Chrome Lighthouse audit score

貢獻者指南

技術棧
htmlcss
領域
accessibilitydocumentation
議題類型
accessibility
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
HTML accessibilitySphinx theme structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the template files that render the prev/next navigation buttons, likely in the theme's layout.html or a partial template. Look for the access key attribute duplication when `theme prev next buttons location` is set to 'both'. Check for any existing PRs or comments. Consider adding unique access keys by location or removing duplicate.
Duplicated access key of the prev and next buttons when prev_next_buttons_location == 'both' · readthedocs/sphinx_rtd_theme#1057 | Good First Issue