reactstrap/reactstrap

Need modal to render in specific div.

Open

#1,011 建立於 2018年5月9日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)JavaScript (10,557 star) (1,347 fork)batch import
PR Welcomeenhancementhelp wantedup-for-grabs

描述

Issue description

  • components: Modal
  • reactstrap version #5.0.0
  • import method umd/csj/es
  • react version #16.3.2
  • bootstrap version #4.1.0

What is happening?

Rendering in the DOM but at the very end.

What should be happening?

I need the modal to render over a specific div. In non-react bootstrap land I can put a modal in an absolutely positioned element and have it render centered over that div. It seems I cannot specify which div I would like the component rendered in here. Is it possible to change that?

Thinking out loud - it would be awesome to have a prop called 'container' or something like that -- so that the default behavior can be exactly as you have it- but if there is a specified container, the modal lives there.

貢獻者指南

技術棧
reactjavascript
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
React basicsReact PortalsModal component
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Examine the Modal component implementation in the source code (likely src/Modal.js). Consider using ReactDOM.createPortal to render the modal into a specified container element. Review existing prop handling and how the modal is currently appended to document.body. Also check any related issues or comments for prior discussion.