reactjs/react-modal

overlayRef and contentRef are undefined on componentDidMount

Open

#740 建立於 2019年2月22日

在 GitHub 查看
 (14 留言) (0 反應) (0 負責人)JavaScript (7,294 star) (828 fork)batch import
easygood first issuemaybe bugmissing documentation

描述

Summary:

overlayRef and contentRef are undefined on componentDidMount, but have the correct value on componentDidUpdate.

Steps to reproduce:

  1. Set the overlayRef and contentRef prop on ReactModal.

  2. console.log the value of overlayRef and contentRef inside componentDidMount.

  3. The values will be undefined.

Expected behavior:

overlayRef and contentRef should hold the correct values on componentDidMount.

Link to example of issue:

https://codesandbox.io/s/qq9kpwxxp9

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Reactrefs in React
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue shows that overlayRef and contentRef are undefined in componentDidMount. Investigation should focus on where the refs are assigned in the component's lifecycle. The linked codesandbox demonstrates the problem. The solution likely involves assigning refs properly in the render method or using callback refs instead of relying on componentDidMount.