reactjs/react-modal

Focus escapes modal when radio buttons in modal

Open

#636 建立於 2018年3月29日

在 GitHub 查看
 (8 留言) (11 反應) (0 負責人)JavaScript (7,294 star) (828 fork)batch import
accessibilitybugeasygood first issue

描述

Summary:

When there are radio buttons in a modal, you can escape focus with shift-tab.

Steps to reproduce:

Steps are included in the test case below

Expected behavior:

You should not be able to escape the modal's focus

Link to example of issue:

https://codesandbox.io/s/my9vm34m68

Additional notes:

Not sure if it's related specifically to radio buttons, but that is what is causing the issue for me

貢獻者指南

技術棧
reactjavascript
領域
frontendaccessibility
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
React basicsFocus management in web appsUnderstanding of tab order
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Investigate the focus trapping logic in the modal component, likely in files like 'src/components/Modal.js' or similar. The provided CodeSandbox (https://codesandbox.io/s/my9vm34m68) demonstrates the issue with Shift+Tab escaping when radio buttons are present. Review the focus management code, particularly how it handles the first and last focusable elements, and ensure radio buttons are properly included in the focus order. Consider using a focus trap library like 'focus trap' or adjusting the existing implementation to handle the radio button's group focus behavior.