reactjs/react-modal

Focus escapes modal when the last element in the modal is an iframe

Open

#226 建立於 2016年9月19日

在 GitHub 查看
 (2 留言) (2 反應) (0 負責人)JavaScript (7,294 star) (828 fork)batch import
bughelp wanted

描述

Summary:

When an iframe is the last element in the modal, focus escapes the modal when using keyboard navigation. This is problematic particularly for screen reader users since the rest of the DOM has aria-hidden set to true. Screen readers are no longer able to access the modal once focus has escaped from it. I used Chrome Version 53.0.2785.116 (64-bit).

Steps to reproduce:

  1. Unzip the modal-test.zip file
  2. Run npm install
  3. Run npm run build
  4. Run node index.js
  5. Navigate to page and tab through until focus escapes the modal (wikipedia has a lot of links so tabbing takes awhile)

Expected behavior:

Focus should be contained within the modal even if an iframe is the last element in the modal.

modal-test.zip

貢獻者指南

技術棧
reactjavascripthtmlcss
領域
accessibilityfrontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactFocus managementAccessibility basicsNode.js/npm
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Investigate the focus trapping mechanism in the React Modal component, particularly the logic that manages keyboard navigation within the modal. Look at the source files under the src/ directory for functions handling focus and iframe elements. Consider testing with the provided test case to reproduce the issue. There may be existing discussions or references in the repository's issues or pull requests that offer insights.