reactjs/react-modal

Add support for React & Node 18 (as easy as adding startTransition() on each setState)

Open

#1,019 建立於 2023年5月8日

在 GitHub 查看
 (19 留言) (0 反應) (0 負責人)JavaScript (7,294 star) (828 fork)batch import
easygood first issue

描述

Summary:

Current react modal doesn't work with latest version of React + Node v18

Steps to reproduce:

  1. Use react-modal with latest React's and Node v18

Expected behavior:

Should work normally

Example of issue:

Breaks with the following error message:

Solution:

Simply add startTransition() wrapping each of the calls for setting the state. startTransition(() => setState("something))

貢獻者指南

技術棧
javascriptreact
領域
frontendaccessibility
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
React fundamentalsstartTransition APIreact modal codebase
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
The issue requires adding startTransition() to each setState call in the react modal component. First, identify all state updates in the source code, likely in the main modal component file. Then, wrap each setState with startTransition to make it compatible with React 18. Ensure no breaking changes and test with the latest React version.
Add support for React & Node 18 (as easy as adding startTransition() on each setState) · reactjs/react-modal#1019 | Good First Issue