reactioncommerce/reaction

Wrong scale for RUB currency

Open

#6,519 建立於 2017年10月27日

在 GitHub 查看
 (8 留言) (2 反應) (0 負責人)JavaScript (12,181 star) (2,198 fork)batch import
buggood first issuehelp wanted

描述

Prices in Russian rubles appears 100 times as much as their correct values. For example, a price "$12.99 - $29.99" shows up in rubles like "75490 - 1 74284 руб." Correct values should be "754,90 - 1 742,84 руб."

Reproduces on the main page and the product details pages.

Fixed this in local database by removing "scale: 0" property from meteor.Shops.currencies.RUB with query: db.Shops.updateMany({}, {$unset: {"currencies.RUB.scale": ""}})

Versions: Node: 6.11.0 NPM: 3.10.10 Meteor Node: 4.8.4 Meteor NPM: 4.6.1 Reaction CLI: 0.19.0 Reaction: 1.5.4 Reaction branch: master

貢獻者指南

技術棧
javascriptnodejsmongodb
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
MongoDB basicsMeteor collection structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue involves a bug where Russian ruble prices are 100x too high due to a 'scale: 0' property in the currencies.RUB field of the Shops collection. The user provided a fix by removing that property via a MongoDB update. To resolve, verify the current state of the Shops collection schema and decide whether to remove the 'scale' property or adjust the scaling logic. Check if any related changes have been made in the codebase since 2017. The fix is localized to the MongoDB document.