react/create-react-app

Allow JSON with comments in jsconfig.json

Open

#7,426 建立於 2019年7月25日

在 GitHub 查看
 (15 留言) (0 反應) (0 負責人)JavaScript (103,386 star) (27,059 fork)batch import
contributions: claimeddifficulty: mediumgood first issueissue: proposal

描述

Is your proposal related to a problem?

This is a follow-on from #7248. Right now, we don't support JSONC (JSON with comments) in jsconfig.json files.

Describe the solution you'd like

After a discussion with @iansu, we see two paths:

  1. Implement the same solution as we did for TypeScript. This is easy, but would require us making TypeScript a dependency of react-scripts.
  2. The above, but instead of installing typescript as a dependency of react-scripts, we would install it to the user's project if they are using a jsconfig.json file and don't have typescript installed.

Discussion is welcome.

If you're interested in picking this up, please let us know.

貢獻者指南

技術棧
javascripttypescript
領域
frontendtoolingbuild system
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Familiarity with JSONCUnderstanding of jsconfig.jsonKnowledge of React scriptsBasic understanding of TypeScript dependency
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Read the linked issue #7248 to understand previous discussions. Evaluate the two proposed solutions: implementing TypeScript support as done for TypeScript (requires making TypeScript a dependency) or installing TypeScript only for jsconfig users without it. Check if the community has expressed a preference. Look at the current codebase to see how tsconfig.json is handled for TypeScript projects. The issue lacks a final decision, so the contributor should propose a clear plan or seek maintainer input.