rapidsai/cudf

Add unit tests for fixed point in quantiles

Open

#9,469 建立於 2021年10月19日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)C++ (6,000 star) (735 fork)batch import
buggood first issuelibcudftests

描述

Describe the bug Quantiles support fixed point columns. but it is not tested in unit tests (both gtest and pytest).

Expected behavior add unit tests for fixed_point in quantiles gtest

Additional context https://github.com/rapidsai/cudf/issues/9468 While adding FixedPointTypes to cudf::test::AllTypes, QUANTILES_TEST (Failed).

[ FAILED ] QuantileUnsupportedTypesTest/10.TestZeroElements, where TypeParam = numeric::fixed_point<int, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/10.TestOneElements, where TypeParam = numeric::fixed_point<int, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/10.TestMultipleElements, where TypeParam = numeric::fixed_point<int, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/11.TestZeroElements, where TypeParam = numeric::fixed_point<long, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/11.TestOneElements, where TypeParam = numeric::fixed_point<long, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/11.TestMultipleElements, where TypeParam = numeric::fixed_point<long, (numeric::Radix)10>

6 FAILED TESTS

貢獻者指南

技術棧
cpppython
領域
testingdata
議題類型
test
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C++CUDAcudfgtest
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Review the quantile test file (likely in cpp/tests/quantile/ or similar) and the existing test suite. Refer to issue #9468 for context on FixedPointTypes. Add FixedPointTypes to the AllTypes list in the quantile test and ensure the tests pass. Investigate the cause of the failures for fixed point with int and long underlying types.