cuIOfeature requestgood first issuelibcudf
倉庫指標
- Star
- (6,000 star)
- PR 合併指標
- (平均合併 17天 21小時) (30 天內合併 230 個 PR)
描述
Improve readability of thread id based branches by giving them more descriptive names.
e.g.
if (!t) // is actually a t == 0
and
https://github.com/rapidsai/cudf/blob/57ef76927373d7260b6a0eda781e59a4c563d36e/cpp/src/io/statistics/column_stats.cu#L285
Is actually a lane_id == 0
As demonstrated in https://github.com/rapidsai/cudf/issues/6241#issuecomment-693125331, prefer cooperative groups for this.
and
https://github.com/rapidsai/cudf/blob/85cd56dfb3449140f18c7cef3a3be01ac976fd14/cpp/src/io/parquet/page_enc.cu#L1256
is actually t < 32lane_id == 31. (I think this might be an oversight, ignore as it might be fixed in #6238 ).