rapidsai/cudf

[FEA] Clean up `type_to_name` and add `print_type` debug utility

已關閉

#17,376 建立於 2024年11月19日

 (5 則留言) (1 個反應) (0 位負責人)C++ (735 個分叉)batch import
feature requestgood first issuelibcudf

倉庫指標

星標
 (6,000 顆星)
PR 合併指標
 (平均合併 17天 21小時) (30 天內合併 230 個 PR)

描述

Is your feature request related to a problem? Please describe. PR #17194 introduces a type_id to string utility located within the benchmark code.

@ttnghia identified that this could be a shared utility for both benchmarks and tests, as it could also be used to create a print_type utility for debugging purposes (see: https://github.com/rapidsai/cudf/pull/17194/files#r1849064965). @davidwendt highlighted that this feature is redundant and performs a similar function to type_to_name.

Describe the solution you'd like

  • Once #17194 is merged, replace stringify_type with type_to_name
  • Replace the type stringify logic in benchmarks/io/nvbench_helpers.hpp with type_to_name
  • Add a host-device print_type utility in cudf_test/print_utilities.cuh using type_to_name for debugging (Note that making it host-device is not mandatory, as type_to_name is currently host-only. However, enabling its use on both host and device, as required by print_type, would involve additional work, such as relocating it to a .cuh header and potentially modifying downstream usage.)

貢獻者指南