raphamorim/react-ape

fix publish GH workflow: publish and tests should not run tests twice

開放

#126 建立於 2022年6月30日

 (0 則留言) (0 個反應) (0 位負責人)JavaScript (47 個分叉)github user discovery
good first issue

倉庫指標

星標
 (1,574 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

Currently the Publish workflow runs together with test, executing the same yarn ci (running tests again) it shouldn't be happening. Should wait for the test workflow check and the follow up with publish.

There's few approaches that could fix it:

  • check if the tests have passed
  • move the publish workflow to tests as a step but only runs if commit message have [publish]

貢獻者指南