qmk/qmk_firmware

Support more than 256 leds

Open

#24,675 建立於 2024年12月4日

在 GitHub 查看
 (6 留言) (2 反應) (0 負責人)C (43,867 fork)batch import
discussionhelp wantedquestion

倉庫指標

Star
 (20,368 star)
PR 合併指標
 (平均合併 20天 9小時) (30 天內合併 27 個 PR)

描述

I made a split keyboard with 4 leds under each key (10 for the 2 2U keys) and the results are pretty spectacular. This sums up to 162 leds per half, or 324 leds on both. QMK currently uses a uint_8 in most places to iterate over leds, so this required some patches which I want to polish up and contribute back.

I'm not intimately familiar with the codebase or nuances of QMK, so it would be great with some guidance on the best way to implement it for this project. I assume RAM is enough of a concern for the AVR platform that replacing all relevant uint_8 with uint_16 would be problematic? Would a typedef uintX_t num_leds_t then be best setting the type to uint16_t if RGB_MATRIX_LED_COUNT > 255, and using that type everywhere instead? Anything else I should know before putting time into implementing this properly?

貢獻者指南