qmk/qmk_firmware

[Bug] Unnecessary delay when pressing the first key after a One-shot key

Open

#14,932 建立於 2021年10月24日

在 GitHub 查看
 (4 留言) (1 反應) (0 負責人)C (43,867 fork)batch import
bughelp wanted

倉庫指標

Star
 (20,368 star)
PR 合併指標
 (平均合併 20天 9小時) (30 天內合併 27 個 PR)

描述

One-shot has 2 behaviors:

  • When the mod-key is tapped, the following keypress is modified
  • When the mod-key is held, all keypresses during the hold are modified

This leads to a necessary delay because if the modifier and then "a" and "b" are pressed in rapid succession, we don't yet know if the mod-key press is a tap or a hold, so we don't know whether to apply the modifier to "b" or not.

However, there the delay is unnecessary for "a". In either case (tap or hold), "a" will be modified, so we can send the modified keypress right away.

貢獻者指南