pytorch/examples

Ambiguous code in reinforce

Open

#297 建立於 2018年2月2日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Python (21,634 star) (9,429 fork)batch import
good first issue

描述

In /reinforcement_learning/reinforce.py, line 91:

running_reward = running_reward * 0.99 + t * 0.01

The variable running_reward seems to used for record average episodic rewards(not actually average, but I think the concept is similar), 0.01, is the scalar to update the average episodic rewards and t is done step. Add some comment or refactor naming may help beginners to understand this example.

貢獻者指南

技術棧
python
領域
documentationmachine learning
議題類型
documentation
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic Pythonreinforcement learning basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
90
研究方向
The issue points to line 91 in `/reinforcement learning/reinforce.py`. The variable `running reward` and the update formula `running reward * 0.99 + t * 0.01` are confusing. A comment explaining that this computes an exponential moving average of episode rewards, or renaming `running reward` to something like `avg reward`, would clarify the code. Check the file for existing comments and coding style. No linked pull requests or maintainer responses are present. Ensure the change is consistent with other examples in the repository.
Ambiguous code in reinforce · pytorch/examples#297 | Good First Issue