pyjanitor-devs/pyjanitor

[ENH] add_column fix

Open

#408 建立於 2019年7月13日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Python (164 fork)batch import
enhancementgood first issuegood intermediate issue

倉庫指標

Star
 (1,217 star)
PR 合併指標
 (平均合併 2天 12小時) (30 天內合併 4 個 PR)

描述

Currently, the add_column function contains the parameter fill_remaining. I believe this parameter could be combined with the value parameter, such that when a list or tuple is inputted into value, it should automatically repeat to fill up the remainder of the column rather than having to specify that in another parameter (fill_remaining). (Also, whenever a list/tuple of a different size from the number of rows is inputted anyway, there is an error. So in my opinion, it would be more efficient to just automatically have the list/tuple iterate until it fills up the remainder of the column solely through inputting the list/tuple into the values parameter rather than also having the fill_remaining parameter.)

is also due to inputting a tuple/list of a different size than the column size will lead to an error anyway)

Relevant Context

貢獻者指南