puppetlabs/puppet

exec resource: path param should default to the path fact

開放

#9,440 建立於 2024年8月3日

 (3 則留言) (1 個反應) (0 位負責人)Ruby (2,214 個分叉)batch import
enhancementhelp wanted

倉庫指標

星標
 (7,854 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

Use Case

For some operations, exec resources are still common. The majority of exec resources I see use hardcoded paths like:

exec { 'nftables_memory_state_check':
  command     => '/bin/echo "reloading nftables"',
  refreshonly => true,
}

This often leads to problems because some distributions use /bin or /usr/bin and others /usr/sbin/. That makes it hard to write the resources for multiple operating systems. because of that I now mostly see this:

exec { 'nftables_memory_state_check':
  command     => 'echo "reloading nftables"',
  refreshonly => true,
  path        => $facts['path'],
}

I think path => $facts['path'], is repeated a lot. Because of that I think the path attribute should default to $facts['path'] when the user does not overwrite it.

Describe the Solution You Would Like

Update path to default to $facts['path'].

Describe Alternatives You've Considered

Using absolute paths or always setting path => $facts['path'],.

Additional Context

貢獻者指南