Generated `debug_sources` are node `Buffer`s and fail `pug_rethrow` · pugjs/pug#3290

(3 留言) (0 反應) (0 負責人)JavaScript (21,509 star) (1,955 fork)batch import

Good First Issuebug

描述

Pug Version: your version number here 3.0.0

Node Version: your version number here 14.7.0

When an included file is read, it's Buffer being stored in debug_sources:

Later, this value is passed to the generator and being serialized as-it in the final render function.

Which fails pug_rethrow's expectation, and makes it throw:

技術棧: javascriptnodejs
領域: backend
議題類型: bug
難度: 3
預計時間: 1-3 hours
活動狀態: fresh
清晰度: clear
前置要求: Node.js basicsUnderstanding of Node.js Buffers
新手友善度: 70
研究方向: The bug is in the pug package's index.js file. Specifically, the debug sources variable stores Buffer objects from readFile (line 167), but the pug rethrow function expects strings (line 256). The fix should convert the Buffer to a string using .toString() before storing or before passing to the generator. Review the linked code lines for exact location and ensure the conversion happens appropriately.