project-chip/connectedhomeip

[CI/CD] Not all CI steps use the same warning levels when compiling

Open

#30,854 建立於 2023年12月6日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)C++ (6,410 star) (1,659 fork)batch import
CI/CD improvementsgood first issuetools

描述

Looks like at least some of our CI / builders let through unused variables. We should turn this on everywhere. see https://github.com/project-chip/connectedhomeip/pull/30793/commits/d3752baacd322a78bcffae4d78fc2b0c64afe72f

Also...some let through code with missing semicolons somehow. I don't even know how that can happen, but see https://github.com/project-chip/connectedhomeip/pull/30793/commits/a14846a9aa48f5f8f8c06603a3ebd97e9c67b636

貢獻者指南

技術棧
ccpp
領域
ci cdbuild system
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C++ compiler flagsCI/CD configurationGitHub Actions
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
Identify all CI configuration files (e.g., .github/workflows, Makefile) where compiler flags are set. Ensure consistent use of Werror for unused variables and Werror for missing semicolons. Refer to PR #30793 commits for examples of flags that were missing. Check each CI step (Linux, Mac, Windows) and add the appropriate flags to the compiler invocations. Verify the changes do not break existing builds.