prettier/prettier

Styled-components template strings formatting

Open

#1,872 建立於 2017年6月2日

在 GitHub 查看
 (21 留言) (41 反應) (0 負責人)JavaScript (51,868 star) (4,716 fork)batch import
area:binary expressionsarea:multiparserhelp wantedlang:css/scss/less

描述

I'm not sure if it's can be fixable and how. But it's very common when using styled-components to write constructions that look like that.

Prettier 1.10.2 Playground link

Input:

const Something = styled.span`
 ${props => props.right && css`
    padding: 10px 134px 10px 20px;
    &:after {
      left: initial;
      right: 30px;
    }
  `}
`

So it looks a bit cleaner, especially for multiple rules. After the latest update, it's broken and looks ugly.

Output:

const Something = styled.span`
  ${props =>
    props.right &&
    css`
      padding: 10px 134px 10px 20px;
      &:after {
        left: initial;
        right: 30px;
      }
    `};
`;

To prove my words, this construction is on the main page first example of styled-components website: https://www.styled-components.com/

貢獻者指南

技術棧
javascriptcss
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptstyled components
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The issue concerns the formatting of nested CSS in JS template literals, specifically within styled components. The expected behavior is to keep the template literal expression inline rather than breaking it across multiple lines. The fix likely involves modifying the expression printing logic in Prettier's JavaScript printer to avoid unnecessary line breaks when the template literal starts with a function call that returns a CSS rule. Review the comments for discussion on potential approaches and test cases.
Styled-components template strings formatting · prettier/prettier#1872 | Good First Issue