prettier/prettier-atom

Check package-lock.json / yarn.lock / node_modules to enable prettier

Open

#191 建立於 2017年6月10日

在 GitHub 查看
 (4 留言) (4 反應) (0 負責人)JavaScript (764 star) (106 fork)batch import
enhancementhelp wanted

描述

Following this tweet: https://twitter.com/RobAWise/status/873443627036549120

Hi guys! Great idea to add this option!

Just curious if the package could also check the contents of package-lock.json / yarn.lock / node_modules in addition to package.json This can be useful for ‘monolithic’ deps similar to react-scripts (create-react-app).

In our team we have an internal linting npm module, which includes eslint-config, eslint itself and prettier-eslint-cli. The two latter packages are not explicitly mentioned in package.json, but node_modules/.bin/eslint and node_modules/.bin/prettier-eslint-cli do exist. This means that we can lint via npm scripts, but can't use the new tick in prettier-atom yet. linter-eslint does seem to detect eslint from node_modules, because linting as-you-type activates correctly in projects when eslint is a dependency of a dependency.

How easy would it be to make the check a bit smarter?

Cheers! Awesome plugin!

貢獻者指南

技術棧
javascriptnodejs
領域
developer experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptAtom plugin API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue requests that prettier atom also checks package lock.json, yarn.lock, or node modules for presence of prettier, in addition to package.json. Review the current detection logic in the plugin's source code, likely in files related to editor activation. Examine how linter eslint handles similar detection from node modules. Implement a function to search for prettier in these locations and update the toggle condition. Test the changes with a project where prettier is a transitive dependency.