plotly/falcon

Refactor Preview.react.js and Settings.react.js

開放

#362 建立於 2018年2月1日

 (15 則留言) (1 個反應) (0 位負責人)JavaScript (279 個分叉)batch import
discussiongood first issuehelp wantedrefactor

倉庫指標

星標
 (5,093 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

cc/ @kcolton @chriddyp @tarzzz

I'm starting this discussion prompted by issues:

  • #360 (poor performance of code editor)
  • #361 (duplicated sql-schemas requests)

Although the code editor lives in CodeEditorField.react.js and the schema preview in TableTree.react.js, it's very likely that we'll have to touch code in their parent components Preview.react.js and Settings.react.js.

I'd like to use this issue to discuss any significant changes to Preview.react.js and Settings.react.js before creating a PR.

貢獻者指南