playcanvas/engine

BoundingBox, BoundingSphere, OrientedBox extra methods.

Open

#858 建立於 2017年2月22日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (8,878 star) (1,325 fork)batch import
enhancementgood first issue

描述

It worth finalizing consistency withing those three classes, so here is list of things to do:

BoundingBox

  1. Deprecate intersects and add another method intersectsBoundingBox which will have same functionality
  2. Add intersectsOrientedBox method
  3. Add center and halfExtents property reference

BoundingSphere

  1. Add intersectsBoundingBox method (calls box.intersectsBoundingSphere internally)
  2. Add intersectsOrientedBox method
  3. Add center and radius property reference

OrientedBox

  1. Add intersectsBoundingBox method (calls box.intersectsOrientedBox internally)
  2. Add intersectsOrientedBox method
  3. Add halfExtents property reference
  4. Property worldTransform has wrong reference

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic 3D geometryJavaScriptFamiliarity with PlayCanvas engineUnderstanding of bounding volumes
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Locate the BoundingBox, BoundingSphere, and OrientedBox classes in the PlayCanvas engine codebase (likely in src/scene/). Review existing methods like intersects, intersectsBoundingSphere, and property references. For BoundingBox: deprecate intersects and add intersectsBoundingBox (same functionality), add intersectsOrientedBox, and add center and halfExtents property references. For BoundingSphere: add intersectsBoundingBox (calling box.intersectsBoundingSphere internally), add intersectsOrientedBox, and add center and radius property references. For OrientedBox: add intersectsBoundingBox (calling box.intersectsOrientedBox), add intersectsOrientedBox, add halfExtents property reference, and fix the worldTransform property reference. Ensure consistency and follow existing coding patterns. Check for any existing implementations or partial work.
BoundingBox, BoundingSphere, OrientedBox extra methods. · playcanvas/engine#858 | Good First Issue