pinojs/pino

bindings() and setBindings() are not present in the browser version of pino

Open

#1,177 建立於 2021年10月20日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)JavaScript (13,157 star) (839 fork)batch import
enhancementgood first issue

描述

Hello!

I was attempting to use pino in the browser today and discovered that .bindings() is undefined. Additionally, .setBindings() is also undefined, but it's also undocumented in general (is it officially part of the API?).

I looked into adding this to browser.js but I'd definitely need some guidance before proceeding. For example, I'm not sure if bindings changes cascade through child loggers or if they are fixed at the time of child creation, for example.

貢獻者指南

技術棧
javascript
領域
backendfrontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
needs maintainer response
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
familiarity with pino's APIknowledge of child logger behavior
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Start by examining the browser.js file in the repository to understand how the browser logger is implemented. Check the documentation for bindings() and setBindings() in the Node.js version. Look at how child loggers are created and if bindings are mutable. The issue author requested guidance, so it would be helpful to review any comments for additional context.