pingcap/tidb

Improve observability of fast reorg ADD INDEX progress

Open

#56,986 建立於 2024年10月30日

在 GitHub 查看
 (6 留言) (0 反應) (1 負責人)Go (40,090 star) (6,186 fork)batch import
component/ddlgood first issuetype/enhancement

描述

Enhancement

currently we only let progress forward when KV is written to TiKV. When fast reorg is enabled, data will be batched on disk for a long time. No progress will be made during that stage and some users may suspect DDL is stuck.

So I propose we draw another line in metrics, which means "how many record KV we have read to assume the index KV".

貢獻者指南

技術棧
goprometheusgrafana
領域
observabilitydatabase
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Go programmingTiDB DDLPrometheusKV store
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Examine the fast reorg implementation in the DDL package, specifically how index data is batched. Identify the existing metrics (e.g., `ddl worker operation duration`) and determine where to add a new metric for record KV reads. Review the Prometheus client library usage in the codebase. Then implement the new metric and update the Grafana dashboard if applicable.
Improve observability of fast reorg ADD INDEX progress · pingcap/tidb#56986 | Good First Issue