pingcap/tidb

executor.Next() should not call chid.Open() or child.Close()

Open

#4,983 建立於 2017年11月2日

在 GitHub 查看
 (1 留言) (0 反應) (1 負責人)Go (40,090 star) (6,186 fork)batch import
help wanted

描述

calling Open() or Close() during Next() makes our executors un-maintainable, for example, if we comment out the following lines then make test, our ut failes ... https://github.com/pingcap/tidb/blob/0616a2fd1511e2206086c212261d93b1106605c7/executor/executor.go#L345

or https://github.com/pingcap/tidb/blob/0616a2fd1511e2206086c212261d93b1106605c7/executor/join.go#L88

Open is used to initialize executors and allocate resources for every executor Close is used to deallocate the resource adopted by every executor, avoid memory leak

貢獻者指南

技術棧
go
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Go programmingunderstanding of executor lifecycle
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
Examine the references in executor/executor.go and executor/join.go to understand the current pattern. Determine the correct places to call Open and Close without violating the Next contract. Ensure that existing tests pass after the refactoring, as noted in the issue that tests fail with current code. Consider the wider executor hierarchy to maintain consistency.