pingcap/tidb
use hack.Slice in ColumnInfo:Dump to avoid unnecessary `string to slice` conversation
已關閉
#32,073 建立於 2022年1月30日
help wantedtype/enhancementtype/performance
倉庫指標
- 星標
- (40,090 顆星)
- PR 合併指標
- (平均合併 14天 4小時) (30 天內合併 346 個 PR)
描述
Enhancement
In some read-heavy workloads, we found that Column Dump causes some CPUs
Through the flamegraph, we can see that nearly 1% of CPU is caused by string to slice conversation. We can ensure that we don't change the slice value in the Dump function, https://github.com/pingcap/tidb/blob/master/server/column.go#L41, so we can use hack.Slice instead.