pingcap/tidb

Failed Query OPM only counts the error count for ComQuery

Open

#16,384 建立於 2020年4月15日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Go (40,090 star) (6,186 fork)batch import
component/metricshelp wantedseverity/minorsig/executiontype/bug

描述

Bug Report

Now, we count the error count in handleQuery which is only valid for ComQuery. Actually, we should count the error for all commands. Or, some errors may be lost if the command is not ComQuery.

https://github.com/pingcap/tidb/blob/master/server/conn.go#L1270-L1287

貢獻者指南

技術棧
go
領域
backendobservabilitydatabase
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
GoServer side error handling
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
Investigate the error counting logic in handleQuery at server/conn.go lines 1270-1287. Understand how errors are currently counted only for ComQuery and determine the appropriate place to count errors for all commands. Consider modifying the main command handler to increment error count for every failed command, not just ComQuery. Ensure that the change does not double count errors or break existing behavior.